Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meta): do configuration change in single barrier #20493

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(meta): do configuration change in single barrier #20493

merged 1 commit into from
Feb 28, 2025

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 13, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Finalize and resolve #18312.

In this PR, we will

  • Change to run all barrier manager commands with a single barrier, and the previous pause-change-resume mechanism will be removed.
  • The PausedReason will be removed, and the pause and resume command will not hold a PausedReason
  • We won't stop inject barrier when there is an inflight pause barrier
  • The wait_epoch_committed rpc will be removed
  • Newly created actors during configuration will start working immediately instead of pause on bootstrap.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 changed the base branch from main to yiming/wait-epoch-when-update-vnode-bitmap February 13, 2025 12:03
@wenym1 wenym1 mentioned this pull request Feb 13, 2025
Merged
8 tasks
@gru-agent Gru Agent
Copy link

gru-agent bot commented Feb 13, 2025 •
edited
Loading

❌ Rebase test pr failed: Error: Pull request #20493 is not created by gru-agent[bot]

@wenym1 wenym1 mentioned this pull request Feb 13, 2025
Merged
8 tasks
@wenym1 Graphite App
Copy link
Contributor Author

wenym1 commented Feb 13, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wenym1 wenym1 force-pushed the yiming/wait-epoch-when-update-vnode-bitmap branch from ee10be7 to 079b77c Compare February 14, 2025 07:00
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch 3 times, most recently from 2dbb354 to 2537f22 Compare February 17, 2025 04:17
@wenym1 wenym1 changed the base branch from yiming/wait-epoch-when-update-vnode-bitmap to yiming/wait-committed-epoch-on-source-split-change February 17, 2025 04:17
@wenym1 wenym1 mentioned this pull request Feb 17, 2025
Merged
8 tasks
Base automatically changed from yiming/wait-committed-epoch-on-source-split-change to main February 20, 2025 08:45
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from 2537f22 to ad38833 Compare February 20, 2025 09:13
@wenym1 wenym1 changed the base branch from main to yiming/wait-epoch-when-update-vnode-bitmap February 20, 2025 09:13
@wenym1 wenym1 force-pushed the yiming/wait-epoch-when-update-vnode-bitmap branch from 832be59 to 5bcc36c Compare February 25, 2025 05:12
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from ad38833 to f7883df Compare February 25, 2025 05:12
Base automatically changed from yiming/wait-epoch-when-update-vnode-bitmap to main February 25, 2025 06:48
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from f7883df to 620c2e5 Compare February 26, 2025 04:15
@wenym1 wenym1 changed the base branch from main to yiming/fix-log-store-scale-data-loss February 26, 2025 04:15
@wenym1 wenym1 mentioned this pull request Feb 26, 2025
Merged
8 tasks
@wenym1 wenym1 force-pushed the yiming/fix-log-store-scale-data-loss branch from f421f54 to 856ea07 Compare February 26, 2025 08:05
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from c4d9946 to e2009bc Compare February 26, 2025 08:06
Base automatically changed from yiming/fix-log-store-scale-data-loss to main February 27, 2025 04:53
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from 214fd61 to 7709bfc Compare February 27, 2025 08:35
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from 7709bfc to c1a22bb Compare February 27, 2025 09:29
BugenZhao
BugenZhao approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm wondering if pause and resume will now be only for debugging purposes (through risectl or pause_on_next_bootstrap)? Do we have any further plan on them?

@wenym1
Copy link
Contributor Author

wenym1 commented Feb 28, 2025

LGTM!

I'm wondering if pause and resume will now be only for debugging purposes (through risectl or pause_on_next_bootstrap)? Do we have any further plan on them?

Not sure about that. For plan, do you mean remove them, or some enhancement on it?

@wenym1 wenym1 added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@wenym1 wenym1 added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 96e09b4 Feb 28, 2025
42 of 44 checks passed
@wenym1 wenym1 deleted the yiming/use-single-barrier-configuration-change branch February 28, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@shanicky shanicky Awaiting requested review from shanicky

@hzxa21 hzxa21 Awaiting requested review from hzxa21

@yezizp2012 yezizp2012 Awaiting requested review from yezizp2012

Assignees
No one assigned
Labels
ci/main-cron/run-all ci/run-backfill-tests ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuration change in a single barrier
2 participants
@wenym1 @BugenZhao